-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update lerna to v7 and migrate to npm workspace #1636
chore: update lerna to v7 and migrate to npm workspace #1636
Conversation
@@ -4,6 +4,7 @@ on: | |||
push: | |||
branches: | |||
- main | |||
- feat-lerna-bootstrap-deprecate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove this later
@@ -5,6 +5,7 @@ on: | |||
- "main" | |||
- "release/**" | |||
- "release-please/**" | |||
- feat-lerna-bootstrap-deprecate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove this later
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1636 +/- ##
==========================================
- Coverage 91.78% 91.38% -0.40%
==========================================
Files 139 129 -10
Lines 7110 6387 -723
Branches 1426 1276 -150
==========================================
- Hits 6526 5837 -689
+ Misses 584 550 -34
|
0f18d14
to
5f5f0d3
Compare
…trib into feat-lerna-bootstrap-deprecate
…/opentelemetry-js-contrib into feat-lerna-bootstrap-deprecate
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This PR was closed because it has been stale for 14 days with no activity. |
Which problem is this PR solving?
lerna bootstrap
,lerna link
, andlerna add
, we must depend on the package's manager native solutionFixes Local build differs from CI build #904
Fixes Update dependency lerna to
v7
#1542Short description of the changes
gts
as it does not use anymore; I just happened to see this because its part of thelerna bootstrap
argumentszone.js
=> instrumentation-user-interaction depends on zone.js's type, but the way the type is defined in zone.js is generated, it can't be used with the import statement. We must use/// <reference
syntax so that we don't need to fix the path tozone.js/dist/zone.js.d.ts
yarn bootstrap
anymore, the previous best practice for node lerna cache not apply for this caseThere might be some hoist issues in the future, and the current npmcli script doesn’t provide enough support for us for more complex hoisting like what
lerna
used to provide.Blocker
example
moduleexample
module use latest code?test-all-version
?Next Step
As lerna@7 is just provide some additional feature on top of nx, ee might consider to include nx.json to increase caching between task and apply for nx-cloud. Nx-cloud should be free for OSS project like opentelemetry-js-contrib. Those change might also fix issue with #1473