fix: span emit warnings on express instrumentation

Signed-off-by: San 'rdn' Mônico <[email protected]>
open-telemetry · Jan 7, 2024 · 97929c7 · 97929c7
1 parent 33b31d0
commit 97929c7
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/plugins/node/opentelemetry-instrumentation-express/src/instrumentation.ts b/plugins/node/opentelemetry-instrumentation-express/src/instrumentation.ts
@@ -280,7 +280,7 @@ export class ExpressInstrumentation extends InstrumentationBase<
             const isError = ![undefined, null, 'route', 'router'].includes(
               maybeError
             );
-            if (isError) {
+            if (!spanHasEnded && isError) {
               const [error, message] = asErrorAndMessage(maybeError);
               span.recordException(error);
               span.setStatus({