Skip to content

Commit

Permalink
fix(test-utils): Don't swallow assertion errors from checkResult an…
Browse files Browse the repository at this point in the history
…d `checkCollector`.
  • Loading branch information
onurtemizkan committed Dec 5, 2024
1 parent 5d60689 commit 782ca9a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion packages/opentelemetry-test-utils/src/test-fixtures.ts
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ export async function runTestFixture(
const collector = new TestCollector();
await collector.start();

return new Promise(resolve => {
return new Promise((resolve, reject) => {
execFile(
process.execPath,
opts.argv,
Expand All @@ -261,6 +261,8 @@ export async function runTestFixture(
if (opts.checkCollector) {
await opts.checkCollector(collector);
}
} catch(err) {
reject(err);
} finally {
collector.close();
resolve();
Expand Down

0 comments on commit 782ca9a

Please sign in to comment.