Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(otelgin): move test files and trim module dependencies #6360

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

flc1125
Copy link

@flc1125 flc1125 commented Nov 22, 2024

No description provided.

@flc1125 flc1125 requested a review from a team as a code owner November 22, 2024 04:46
CHANGELOG.md Outdated Show resolved Hide resolved
@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.9%. Comparing base (7a12292) to head (5699ce0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6360   +/-   ##
=====================================
  Coverage   66.9%   66.9%           
=====================================
  Files        193     193           
  Lines      15652   15652           
=====================================
+ Hits       10479   10482    +3     
+ Misses      4882    4880    -2     
+ Partials     291     290    -1     
Files with missing lines Coverage Δ
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go 84.0% <ø> (ø)

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not having b3 as a dependency of the instrumentation anymore is nice.

@pellared pellared changed the title tests(otelgin): move test files and simplify main package dependencies tests(otelgin): move test files and trim module dependencies Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants