-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run genjsonschema in CI #6353
base: main
Are you sure you want to change the base?
Run genjsonschema in CI #6353
Conversation
6a5ff57
to
2cac67e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Wasn't sure where to add this when updating the types, but this is the obvious next step to make sure they don't go out-of-date.
CC @codeboten |
@open-telemetry/go-approvers this needs a second review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6353 +/- ##
=====================================
Coverage 66.9% 66.9%
=====================================
Files 193 193
Lines 15652 15647 -5
=====================================
+ Hits 10479 10481 +2
+ Misses 4882 4876 -6
+ Partials 291 290 -1 |
addecb8
to
bbf3451
Compare
#6347 is updating the generated JSON schema, as it has changed with upgrades of
go-jsonschema
.We update the binary semi automatically with dependabot. However, this means there could be unseen regressions or changes like this that we miss.
This runs the schema generation on CI, before checking for a clean repository, so we can keep the generated code up to date with the binary version.
This should fail until #6347 and #6349 are merged.