-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add key type specific en- decoder #596
Conversation
I don't know why DCO check is failing. My primary EMail is [email protected]. |
DCO "validation" is nothing I ever understood. @ryjones can you help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for these additional en/decoders @wbeck10 ! May I ask how you did that code without using the jinja2 code generator? Or did you use it? If so, please be sure to also add the changed fragment files to the commit, e.g., https://github.com/open-quantum-safe/oqs-provider/blob/main/oqs-template/oqsprov/oqs_decode_der2key.c/decoder_make.fragment adding all "type_specific_keypair" MAKE_DECODER statements. If not, please use them so this gets auto-generated on every new change of algorithms when running oqs-template/generate.py
.
@baentsch @wbeck10 if you look here you will see if you look:
The Author and Signed-off-by do not match. |
This is my old EMail I've used before working in Oracle, I've changed my primary EMail to the Oracle EMail a long time ago. Maybe a bug in Github? |
I don't believe GitHub sets the author email for a commit, I think that would be up to your git config. ( |
correct |
commit 92c5639 Author: wbeck10 <[email protected]> Date: Wed Dec 4 03:07:57 2024 +0000 Add key type specific en- decoder Signed-off-by: Wolfgang Beck <[email protected]>
Will create a new one |
New PR: |
Encoding and decoding of oqs keys using type specific en- / decoding is not working.
This pull requests adds type specific key der en- / decoding.
This PR will solve Fixes #562
#562