-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.8.0 branch #593
base: main
Are you sure you want to change the base?
0.8.0 branch #593
Conversation
Signed-off-by: Pravek Sharma <[email protected]>
Signed-off-by: Pravek Sharma <[email protected]>
Signed-off-by: Pravek Sharma <[email protected]>
Signed-off-by: Pravek Sharma <[email protected]>
Signed-off-by: Pravek Sharma <[email protected]>
Signed-off-by: Pravek Sharma <[email protected]>
Thank you for the suggestions @baentsch! I've included the changes here and on the draft pre-release: https://github.com/open-quantum-safe/oqs-provider/releases/tag/untagged-0fb2ad16a1ba976ea75a |
Signed-off-by: Pravek Sharma <[email protected]>
Signed-off-by: Pravek Sharma <[email protected]>
@baentsch @SWilson4 @ghen2 @fwh-dc Thank you for you suggestions, I've updated README.md to include them and updated the draft pre-release as well: https://github.com/open-quantum-safe/oqs-provider/releases/tag/untagged-d43fdf73a30644bc1820 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
Signed-off-by: Michael Baentsch <[email protected]>
Following guidance in https://github.com/open-quantum-safe/oqs-provider/wiki/Release-process this removed "rc1" tags and waits for approval to land. Final release will be cut on the landed (squashed) commit. |
Thank you for finishing up the final release steps @baentsch! The pre-release is still in draft, is that intentional? Please let me know if that is becuase the GitHub web UI won't let you publish it and I shall do the same. I'm linking a discussion related to the 0.7.0 release to see if we'd like to wait for a little bit before proceeding with the final release after appropriate approvals since I have not been able to automate the release process yet: #534 (comment) |
Thanks for the reminder to move rc1 out of Draft, @praveksharma . Just done. And sure, 0.8.0 will sit un-merged for a day before I squash, commit, and release (as agreed in the call yesterday) - just in case :) |
Looking at open-quantum-safe/boringssl#130 I wonder whether we should also at least announce removal of Dilithium with the next release (along the lines of Kyber)? fwiw, I very much like the approach taken by @pi-314159 for oqs-boringssl: Just yank the stuff that's outdated... Or maybe it's just envy :-) @open-quantum-safe/oqs-committers do you know of anyone still relying on Kyber and Dilithium still being supported? May it be an idea to mark them "disabled" already now in the generate.yml? This would functionally align oqsprovider and oqsboringssl and still allow anyone to enable those algs again if they absolutely must. |
The liboqs 0.12.0 release notes didn't mention the planned removal of Dilithium, so the sequencing we've been following lately would have us announce the removal of Dilithium in 0.13.0 and then remove it by 0.14.0. That being said, oqs-provider could announce earlier, if you wanted. |
Signed-off-by: Michael Baentsch <[email protected]>
Please see the relevant pre-release (currently in draft): https://github.com/open-quantum-safe/oqs-provider/releases/tag/untagged-e8b2d0985929c684a8d5
This PR makes the following changes:
generate.yml
asgenerate.yml-0.12.0
,SECURITY.md
,RELEASE.md
,Checks done:
generate.py
anddo_code_format.sh
,release-tests.sh
with liboqs 0.12.0 and openssl 3.4.0 runs OK,gh act --job external-tests-providers
. (Logs attached: logs.txt. Note that the external-tests-providers jobs fails because the tests for pkcs11-provider fail but oqs-provider passes.).This PR will not land; once approved, a new 0.8.0-release PR will be made.