Address some Static Analysis Issues #519 #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Norman Ashley <[email protected]>
Signed-off-by: Norman Ashley <[email protected]>
Signed-off-by: Norman Ashley <[email protected]>
Signed-off-by: Norman Ashley <[email protected]>
|
Thanks @baentsch, i am not sure if i needed another approval, so adding a few more reviewers. |
|
No, 1 review is sufficient in a project with as many maintainers :-) Do you have permissions to merge? |
dstebila
approved these changes
Sep 17, 2024
|
@ashman-p Is it possible that you merged this without squashing? The commit history at least got substantially longer that I'd figure it should be. If no, please do so in the future to keep things together that belong together. Thanks! |
I think that was the case. I will remember to squash be the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some static analysis errors reported by Coverity tool.