add support for the CMAKE_PARAMS environment variable

[jschauma]

I was unable to convince fullbuild.sh to use the right OpenSSL library from /opt/lib64 by setting OPENSSL_ROOT_DIR=/opt nor by setting OPENSSL_INSTALL=/opt or other variations I tried. It seemed I needed to invoke cmake with -DOPENSSL_CRYPTO_LIBRARY="/opt/lib64/libcrypto.so", but there was no obvious way to get this flag passed into the script.

Adding a generic CMAKE_FLAGS environment variable allows me to pass this flag and would allow others to set additional flags they might need, and falls in line with common Unix practice of supporting e.g., CFLAGS, LDFLAGS etc.

Perhaps this is useful to somebody else.

[baentsch]

Thanks for the contribution, @jschauma . Basically LGTM. Just one nit: What's the advantage of naming this variable "CMAKE_FLAGS"? The name "CMAKE_PARAMS" would be more in line with its "sibling" parameters... If you'd agree, please just update the PR, I'd squash-merge afterwards.

[baentsch]

Ah, and please "sign" your commit (option -s) to confirm you're OK with the project's license terms (making the bean-counters at LinuxFoundation happy), i.e., so the "DCO" test passes. The other CI failures are due to a recent upstream merge that should be resolved by merging #461.

[jschauma]

Ok, just 'git commit -s'd the s/FLAGS/PARAMS/ change.

[beldmit]

@jschauma does it mean that it becomes possible to build all the chain (openssl => liboqs => oqs-provider) without installing the previous components?

[jschauma]

I had installed OpenSSL manually into /opt, then ran

env OPENSSL_ROOT=/opt CMAKE_PARAMS="-DOPENSSL_CRYPTO_LIBRARY=/opt/lib64/libcrypto.so" bash scripts/fullbuild.sh

and that built liboqs and oqs-provider successfully. I didn't test having fullbuild.sh build OpenSSL (mainly because I didn't want bleeding edge from git, but a stable release).

[baentsch]

it becomes possible to build all the chain (openssl => liboqs => oqs-provider) without installing the previous components?

This precisely is the purpose of the script from the start (and it is used in this way in CI to build-test the chain). The most important env var to set IMO, though, is OPENSSL_BRANCH: If not set, any openssl (>=3.0) available will be used and no from-scratch build is done.

[jschauma]

Thanks for merging!

[baentsch]

Thanks for merging!

Thanks for improving the system!