Fix various MacOS build warnings

[ashman-p]

Address a few warning see on MacOS M1.
oqsprovider-MacOS-warnings.txt

Fixes #467.

[ashman-p]

I am getting the following error running the formatter manually.
Can anyone give me some pointers to resolve?

@ashman-p ➜ /workspaces/oqs-provider-fix-warnings (main) $
@ashman-p ➜ /workspaces/oqs-provider-fix-warnings (main) $ find . -type f -and '(' -name '.h' -or -name '.c' -or -name '*.inc' ')' | xargs clang-format --dry-run --Werror
YAML:75:25: error: invalid boolean
AlignConsecutiveMacros: AcrossComments
^~~~~~~~~~~~~~
Error reading /workspaces/oqs-provider-fix-warnings/./.clang-format: Invalid argument
YAML:75:25: error: invalid boolean
AlignConsecutiveMacros: AcrossComments
^~~~~~~~~~~~~~

[ghost]

LGTM, except for the upgraded minimum cmake version.

[ghost]

I am getting the following error running the formatter manually. Can anyone give me some pointers to resolve?

@ashman-p ➜ /workspaces/oqs-provider-fix-warnings (main) $ @ashman-p ➜ /workspaces/oqs-provider-fix-warnings (main) $ find . -type f -and '(' -name '.h' -or -name '.c' -or -name '*.inc' ')' | xargs clang-format --dry-run --Werror YAML:75:25: error: invalid boolean AlignConsecutiveMacros: AcrossComments ^~~~~~~~~~~~~~ Error reading /workspaces/oqs-provider-fix-warnings/./.clang-format: Invalid argument YAML:75:25: error: invalid boolean AlignConsecutiveMacros: AcrossComments ^~~~~~~~~~~~~~

What version of clang-format are you using?

[baentsch]

I am getting the following error running the formatter manually. Can anyone give me some pointers to resolve?
@ashman-p ➜ /workspaces/oqs-provider-fix-warnings (main) $ @ashman-p ➜ /workspaces/oqs-provider-fix-warnings (main) $ find . -type f -and '(' -name '.h' -or -name '.c' -or -name '*.inc' ')' | xargs clang-format --dry-run --Werror YAML:75:25: error: invalid boolean AlignConsecutiveMacros: AcrossComments ^~~~~~~~~~~~~~ Error reading /workspaces/oqs-provider-fix-warnings/./.clang-format: Invalid argument YAML:75:25: error: invalid boolean AlignConsecutiveMacros: AcrossComments ^~~~~~~~~~~~~~

What version of clang-format are you using?

This may pertain to #473 (also a clang version related formatting issue).

[baentsch]

Why did this get closed? The code looked like a valid fix and with the formatting update this should have passed CI, no?

[ashman-p]

I was having problems getting coding formatting tests to pass on the branch. In my attempts to address that I sync'ed with your latest your changes in 'main'. That made things worst for the branch so, i decided to start over which closed the PR. Please stay tuned for a new PR.