Fix #440: disable tests and examples using BUILD_TESTING.
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
marked this pull request as ready for review
baentsch
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Makes sense as-is, Thanks! Just wondering whether it may be even better to document explicitly that all ctest config vars (as all other cmake config options) drive the oqsprovider build (in CONFIGURE.md)? Please amend/merge at your discretion, @thb-sb
By providing cmake with `BUILD_TESTING=OFF`, no test or example will be built. `BUILD_TESTING` is `ON` by default, since we are using [`enable_testing`] along with `CTest`. [`enable_testing`]: https://cmake.org/cmake/help/latest/command/enable_testing.html Signed-off-by: thb-sb <[email protected]>
Makes total sense! I've added an entry for |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #440: disable tests and examples using
BUILD_TESTING.By providing cmake with
BUILD_TESTING=OFF, no test or example will be built.BUILD_TESTINGisONby default, since we are usingenable_testingalong withCTest.Signed-off-by: thb-sb [email protected]