Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken circleci job for macOS #305

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

johnma14
Copy link
Contributor

This PR updates the openssl version to be installed for testing macOS builds

The circleci config file currently points to [email protected] to install openssl for macOS. This change was made as part of the following PR, where previously openssl@3 pointed to openssl v3.0.x which was causing errors trying to build oqs-provider. So the change was made to specify [email protected]. OpenSSL v3.2 was released last week and the circleci jobs for macOS started failing since [email protected] is no longer available to install using homebrew. Instead the following are the options: openssl@3 (which points to the current stable version, v3.2), [email protected] and [email protected].

Changes made in this PR include:

  • pointing the openssl version back to openssl@3 since it now points to the latest 3.2
  • a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (This command no longer accepts the --job option)

@johnma14 johnma14 requested a review from baentsch as a code owner November 29, 2023 20:00
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually the update looks good (except for the single comment just made). But why are there so many CI tasks failing currently?

@ghost
Copy link

ghost commented Nov 30, 2023

LGTM too.
CI jobs are failing because a documentation file is not matching a generated file… looks weird to me

@baentsch
Copy link
Member

looks weird to me

Actually, pretty unacceptable: The difference is in HQC: It seems like oqsprovider picked up the new HQC version -- without updated code points. My mistake (to not have been online :) as the merge of open-quantum-safe/liboqs#1585 should (must) have led to a code-point-updating PR in oqsprovider (fyi @SWilson4 @dstebila to help implement the things we write in liboqs PR: Pretty much at the time of merging such algorithm changes we ought to have downstream PRs available). #306 created to fix.

@johnma14
Copy link
Contributor Author

@baentsch @thb-sb Thank you for figuring out the failing test issue. I was having a hard time figuring that out. Regarding the doc change in this PR, I can remove that but I found that while working on this and trying to do a local CI build. I have the latest version of CircleCI installed (which is v0.1.29314) and that doesn't have the --log option for circleci local execute command.

image

@baentsch
Copy link
Member

that doesn't have the --log option for circleci local execute command

Ah, OK. Thanks for the explanation. And more importantly, it also doesn't have the --job option. What about just adding "[" "]" around --job then?

@baentsch
Copy link
Member

Thank you for figuring out the failing test issue. I was having a hard time figuring that out.

Well, apologies for having you try to do this. This should not have happened to begin with.

@johnma14
Copy link
Contributor Author

that doesn't have the --log option for circleci local execute command

Ah, OK. Thanks for the explanation. And more importantly, it also doesn't have the --job option. What about just adding "[" "]" around --job then?

Yes, that makes sense. Will do that. Thanks @baentsch

@johnma14
Copy link
Contributor Author

Thank you for figuring out the failing test issue. I was having a hard time figuring that out.

Well, apologies for having you try to do this. This should not have happened to begin with.

No worries, its always good learning.

@SWilson4
Copy link
Member

(fyi @SWilson4 @dstebila to help implement the things we write in liboqs PR: Pretty much at the time of merging such algorithm changes we ought to have downstream PRs available).

Noted, will do in the future. (In the near future, hopefully, for Falcon.)

CONTRIBUTING.md Outdated Show resolved Hide resolved
@baentsch
Copy link
Member

baentsch commented Dec 1, 2023

Please rebase to latest main and CI should turn green.

This PR updates the openssl version to be installed for testing macOS builds

The circleci config file currently points to [email protected] to install openssl for macOS. This change was made as
part of the following [PR](open-quantum-safe@080c3dd),
where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider.
So the change was made to specify `[email protected]`. OpenSSL v3.2 was released last week and the circleci jobs for
macOS started failing since `[email protected]` is no longer available to install using homebrew. Instead the following
are the options: `openssl@3` (which points to the current stable version, v3.2), `[email protected]` and `[email protected]`.

Changes made in this PR include:
- pointing the openssl version back to `openssl@3` since it now points to the latest 3.2
- a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest
  version (currently vv0.1.29314), this command does not have the --job flag)
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @johnma14 !

@baentsch baentsch merged commit ced75e4 into open-quantum-safe:main Dec 5, 2023
22 checks passed
baentsch pushed a commit that referenced this pull request Dec 23, 2023
This PR updates the openssl version to be installed for testing macOS builds

The circleci config file currently points to [email protected] to install openssl for macOS. This change was made as
part of the following [PR](080c3dd),
where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider.
So the change was made to specify `[email protected]`. OpenSSL v3.2 was released last week and the circleci jobs for
macOS started failing since `[email protected]` is no longer available to install using homebrew. Instead the following
are the options: `openssl@3` (which points to the current stable version, v3.2), `[email protected]` and `[email protected]`.

Changes made in this PR include:
- pointing the openssl version back to `openssl@3` since it now points to the latest 3.2
- a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest
  version (currently vv0.1.29314), this command does not have the --job flag)
baentsch pushed a commit that referenced this pull request Dec 24, 2023
This PR updates the openssl version to be installed for testing macOS builds

The circleci config file currently points to [email protected] to install openssl for macOS. This change was made as
part of the following [PR](080c3dd),
where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider.
So the change was made to specify `[email protected]`. OpenSSL v3.2 was released last week and the circleci jobs for
macOS started failing since `[email protected]` is no longer available to install using homebrew. Instead the following
are the options: `openssl@3` (which points to the current stable version, v3.2), `[email protected]` and `[email protected]`.

Changes made in this PR include:
- pointing the openssl version back to `openssl@3` since it now points to the latest 3.2
- a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest
  version (currently vv0.1.29314), this command does not have the --job flag)
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 13, 2024
This PR updates the openssl version to be installed for testing macOS builds

The circleci config file currently points to [email protected] to install openssl for macOS. This change was made as
part of the following [PR](open-quantum-safe@080c3dd),
where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider.
So the change was made to specify `[email protected]`. OpenSSL v3.2 was released last week and the circleci jobs for
macOS started failing since `[email protected]` is no longer available to install using homebrew. Instead the following
are the options: `openssl@3` (which points to the current stable version, v3.2), `[email protected]` and `[email protected]`.

Changes made in this PR include:
- pointing the openssl version back to `openssl@3` since it now points to the latest 3.2
- a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest
  version (currently vv0.1.29314), this command does not have the --job flag)

Signed-off-by: Felipe Ventura <[email protected]>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 16, 2024
This PR updates the openssl version to be installed for testing macOS builds

The circleci config file currently points to [email protected] to install openssl for macOS. This change was made as
part of the following [PR](open-quantum-safe@080c3dd),
where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider.
So the change was made to specify `[email protected]`. OpenSSL v3.2 was released last week and the circleci jobs for
macOS started failing since `[email protected]` is no longer available to install using homebrew. Instead the following
are the options: `openssl@3` (which points to the current stable version, v3.2), `[email protected]` and `[email protected]`.

Changes made in this PR include:
- pointing the openssl version back to `openssl@3` since it now points to the latest 3.2
- a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest
  version (currently vv0.1.29314), this command does not have the --job flag)

Signed-off-by: Felipe Ventura <[email protected]>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 16, 2024
This PR updates the openssl version to be installed for testing macOS builds

The circleci config file currently points to [email protected] to install openssl for macOS. This change was made as
part of the following [PR](open-quantum-safe@080c3dd),
where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider.
So the change was made to specify `[email protected]`. OpenSSL v3.2 was released last week and the circleci jobs for
macOS started failing since `[email protected]` is no longer available to install using homebrew. Instead the following
are the options: `openssl@3` (which points to the current stable version, v3.2), `[email protected]` and `[email protected]`.

Changes made in this PR include:
- pointing the openssl version back to `openssl@3` since it now points to the latest 3.2
- a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest
  version (currently vv0.1.29314), this command does not have the --job flag)

Signed-off-by: Felipe Ventura <[email protected]>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
This PR updates the openssl version to be installed for testing macOS builds

The circleci config file currently points to [email protected] to install openssl for macOS. This change was made as
part of the following [PR](open-quantum-safe@080c3dd),
where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider.
So the change was made to specify `[email protected]`. OpenSSL v3.2 was released last week and the circleci jobs for
macOS started failing since `[email protected]` is no longer available to install using homebrew. Instead the following
are the options: `openssl@3` (which points to the current stable version, v3.2), `[email protected]` and `[email protected]`.

Changes made in this PR include:
- pointing the openssl version back to `openssl@3` since it now points to the latest 3.2
- a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest
  version (currently vv0.1.29314), this command does not have the --job flag)

Signed-off-by: Felipe Ventura <[email protected]>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
This PR updates the openssl version to be installed for testing macOS builds

The circleci config file currently points to [email protected] to install openssl for macOS. This change was made as
part of the following [PR](open-quantum-safe@080c3dd),
where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider.
So the change was made to specify `[email protected]`. OpenSSL v3.2 was released last week and the circleci jobs for
macOS started failing since `[email protected]` is no longer available to install using homebrew. Instead the following
are the options: `openssl@3` (which points to the current stable version, v3.2), `[email protected]` and `[email protected]`.

Changes made in this PR include:
- pointing the openssl version back to `openssl@3` since it now points to the latest 3.2
- a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest
  version (currently vv0.1.29314), this command does not have the --job flag)

Signed-off-by: Felipe Ventura <[email protected]>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
This PR updates the openssl version to be installed for testing macOS builds

The circleci config file currently points to [email protected] to install openssl for macOS. This change was made as
part of the following [PR](open-quantum-safe@080c3dd),
where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider.
So the change was made to specify `[email protected]`. OpenSSL v3.2 was released last week and the circleci jobs for
macOS started failing since `[email protected]` is no longer available to install using homebrew. Instead the following
are the options: `openssl@3` (which points to the current stable version, v3.2), `[email protected]` and `[email protected]`.

Changes made in this PR include:
- pointing the openssl version back to `openssl@3` since it now points to the latest 3.2
- a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest
  version (currently vv0.1.29314), this command does not have the --job flag)

Signed-off-by: Felipe Ventura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants