-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support web proxy in external interop tests #288
Conversation
Update oqsprovider-externalinterop.sh to support web proxy in external interop tests. To determine whether to resort to proxy handling, checks if env var `HTTP_PROXY` is set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@baentsch when do you think this one would be merged? I'm eager to delete my fork of this repo. |
Are you charged for having this fork? I've been trying to understand why CI's failing on this/what's going wrong with the Windows build. Or in other words, I'm not eager merging something with CI failing. But then again, your code has nothing to do with this, so I bite this bullet. |
He... Not really - but I already have more repos up here than is comfortable, so I'm trying to keep their number down.
That would be interesting to know - but as you pointed out:
Exactly. I'm willing to bet that other CI on this repo also fail on Windows. Of course, I've no idea whether OpenSSL app (executable) on Windows accepts the same parameters (
Thanks! |
Update oqsprovider-externalinterop.sh to support web proxy in external interop tests. To determine whether to resort to proxy handling, checks if env var `HTTP_PROXY` is set Signed-off-by: Felipe Ventura <[email protected]>
Update oqsprovider-externalinterop.sh to support web proxy in external interop tests. To determine whether to resort to proxy handling, checks if env var `HTTP_PROXY` is set Signed-off-by: Felipe Ventura <[email protected]>
Update oqsprovider-externalinterop.sh to support web proxy in external interop tests. To determine whether to resort to proxy handling, checks if env var `HTTP_PROXY` is set Signed-off-by: Felipe Ventura <[email protected]>
Update oqsprovider-externalinterop.sh to support web proxy in external interop tests. To determine whether to resort to proxy handling, checks if env var `HTTP_PROXY` is set Signed-off-by: Felipe Ventura <[email protected]>
Update oqsprovider-externalinterop.sh to support web proxy in external interop tests. To determine whether to resort to proxy handling, checks if env var `HTTP_PROXY` is set Signed-off-by: Felipe Ventura <[email protected]>
Update oqsprovider-externalinterop.sh to support web proxy in external interop tests. To determine whether to resort to proxy handling, checks if env var
HTTP_PROXY
is setFixes #282