Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add key type specific en- decoder #596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add key type specific en- decoder #596

wants to merge 1 commit into from
+596 −52

Conversation

wbeck10
Copy link

@wbeck10 wbeck10 commented Dec 18, 2024

Encoding and decoding of oqs keys using type specific en- / decoding is not working.
This pull requests adds type specific key der en- / decoding.

This PR will solve Fixes #562

#562

@wbeck10 wbeck10 requested a review from baentsch as a code owner December 18, 2024 03:04
@wbeck10 wbeck10 mentioned this pull request Dec 18, 2024
Open
@wbeck10
Copy link
Author

wbeck10 commented Dec 18, 2024

I don't know why DCO check is failing. My primary EMail is [email protected].

@baentsch
Copy link
Member

I don't know why DCO check is failing. My primary EMail is [email protected].

DCO "validation" is nothing I ever understood. @ryjones can you help?

baentsch
baentsch requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for these additional en/decoders @wbeck10 ! May I ask how you did that code without using the jinja2 code generator? Or did you use it? If so, please be sure to also add the changed fragment files to the commit, e.g., https://github.com/open-quantum-safe/oqs-provider/blob/main/oqs-template/oqsprov/oqs_decode_der2key.c/decoder_make.fragment adding all "type_specific_keypair" MAKE_DECODER statements. If not, please use them so this gets auto-generated on every new change of algorithms when running oqs-template/generate.py.

@ryjones
Copy link

ryjones commented Dec 18, 2024

@baentsch @wbeck10 if you look here you will see No sign-off matches the author or committer

if you look:

commit 92c5639424a5f847a22e86cf76daf28f20844113 (HEAD -> encdec)
Author: wbeck10 <[email protected]>
Date:   Wed Dec 4 03:07:57 2024 +0000

    Add key type specific en- decoder
    
    Signed-off-by: Wolfgang Beck <[email protected]>

The Author and Signed-off-by do not match.

@wbeck10
Copy link
Author

wbeck10 commented Dec 18, 2024

@baentsch @wbeck10 if you look here you will see No sign-off matches the author or committer

if you look:

commit 92c5639424a5f847a22e86cf76daf28f20844113 (HEAD -> encdec)
Author: wbeck10 <[email protected]>
Date:   Wed Dec 4 03:07:57 2024 +0000

    Add key type specific en- decoder
    
    Signed-off-by: Wolfgang Beck <[email protected]>

The Author and Signed-off-by do not match.

This is my old EMail I've used before working in Oracle, I've changed my primary EMail to the Oracle EMail a long time ago. Maybe a bug in Github?

@SWilson4
Copy link
Member

This is my old EMail I've used before working in Oracle, I've changed my primary EMail to the Oracle EMail a long time ago. Maybe a bug in Github?

I don't believe GitHub sets the author email for a commit, I think that would be up to your git config. (git config user.email)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baentsch baentsch baentsch requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

i2d_PublicKey() fails with -1 for DILITHIUM2 key while using OQS provider with OpenSSL 3.2.1
5 participants
@wbeck10 @baentsch @ryjones @SWilson4 @wbeck10p