Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scientific-SNAP branch. Provides means of leveraging Xilinx ap_fixed … #850

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fmdepaul
Copy link

Scientific-SNAP fork. Provides means for leveraging Xilinx ap_fixed data-type for both sw and hw actions. Added hls_double_mult app based on said data-type .

Signed-off-by: Flavio M. de Paula [email protected]

…data-type for both sw and hw actions. Added hls_double_mult app based on said data-type version

Signed-off-by: Flavio M. de Paula <[email protected]>
@fmdepaul
Copy link
Author

fmdepaul commented Nov 24, 2018

Found some issues and addressed on on SHA 32c1f8a

@fmdepaul fmdepaul closed this Nov 24, 2018
@fmdepaul fmdepaul reopened this Nov 24, 2018
Flavio M. de Paula added 2 commits November 24, 2018 12:13
Signed-off-by: Flavio M. de Paula <[email protected]>
@bmesnet
Copy link
Collaborator

bmesnet commented Nov 26, 2018

@fmdepaulf
Hi Flavio, You may have missed the information that from the hls_double_mult, I have created a clean release named hls_decimal_mult (and removed the old one). This release takes care of the simple and double floating point and is more parameterized . It may be easier to maintain one unique release. Are your changes applicable to this already registered action? Thx

@bmesnet bmesnet self-requested a review November 26, 2018 09:54
@fmdepaul
Copy link
Author

@bmesnet
Hi Bruno, I uploaded this ap_fixed version of hls_double_mult so that folks have available to them two different approaches to deal with single and double floating-point precision numbers. I didn't intend to overwrite hls_decimal_mult. However, given that I have hls_decimal_mult with ap_fixed in my sandbox. I could either upload it with an alternative name or overwrite the existing one. Let me know what you prefer. I would then delete hls_double_mult.
To reiterate my point, I think it would be a good idea to have those two approaches as examples since, in fact, they handle float/doubles in different ways. Please, let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants