Workaround to mark unused IOHS targets #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Bonnell MRW, some IOHS targets are marked with UNUSED for the IOHS_CONFIG_TYPE attribute. So such targets need to be marked non-functional to prevent boot failures. Test: Applied patch and verified that the unused IOHS are marked as non-functional. Signed-off-by: aravnair-in <[email protected]>
ojayanth
suggested changes
Mar 15, 2023
| //@Brief Function will mark targets as non present in the devtree | ||
| //if it is marked UNUSED in the MRW. This is a workaround for | ||
| //handling unused IOHS targets in Bonnell. | ||
| static bool process_unused_targets() |
There was a problem hiding this comment.
Only required to update primary processor on genesis boot. update_genesis_hwas_state() used to set hwas state update in genesis mode. you can create helper function to read attribute and set iohs targes based on attribute state.
dcrowell77
approved these changes
Mar 15, 2023
|
please review here as aravind is out for few days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Bonnell MRW, some IOHS targets are marked with UNUSED
for the IOHS_CONFIG_TYPE attribute. So such targets need to
be marked non-functional to prevent boot failures.
Test:
Applied patch and verified that the unused IOHS are marked
as non-functional.