Combinatorial: warn if TestRun or MiddlewareGet sections are missing #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joseph Schuchart <[email protected]>
|
I'm not opposed to this change. Have you tested that this fails with the better error message when either TestRun or MiddlewareGet is missing? |
|
I did, it throws the warning that I added if either of this sections are missing. |
|
Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Combinatorial executor would fail with a cryptic error saying that no run log is available. Be a little nicer and at least say what's missing...
Addresses #891 (not sure it's a real fix, just playing a little nicer)
Signed-off-by: Joseph Schuchart [email protected]