-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make mmseg to be able to run on mmcv=2.2.0 #3663
base: main
Are you sure you want to change the base?
Conversation
1. Documentation says it is okay to run with mmcv >= 2.2.0 but mmseg incorrectly asserts. 2. Provide better error messages to pinpoint if the versions are higher or lower
mmseg/__init__.py
Outdated
@@ -8,7 +8,7 @@ | |||
from .version import __version__, version_info | |||
|
|||
MMCV_MIN = '2.0.0rc4' | |||
MMCV_MAX = '2.2.0' | |||
MMCV_MAX = '2.3.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directly changing the support version may be dangerous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
can we get this merged? |
I believe it's OK, but I am just a contributor without merge permission. This project has been paused for several months. ----From a dissappointed contributor......... |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
The documentation says it is okay to run with
mmcv >= 2.2.0
, butmmseg
incorrectly asserts it to be less than 2.2.0.Modification
mmcv
with version 2.2.0 to run with the latestmmseg
package.BC-breaking (Optional)
No
Use cases (Optional)
N/A
Checklist