update close channel api to be future compatible

[RnkSngh]

Summary by CodeRabbit

• Refactor
  • Enhanced the channel closure process in smart contracts by splitting it into initialization and confirmation steps, improving clarity and control over the channel lifecycle.
• Bug Fixes
  • Resolved stack-too-deep errors in smart contract upgrades by optimizing argument encoding and refining function parameters.
• Documentation
  • Updated comments and structured code for better understanding and maintenance.

[coderabbitai]

Walkthrough

The recent updates involve the refactoring of channel closure functions in IBC-related smart contracts, splitting them into initialization and confirmation stages. This change enhances clarity and modularity in handling channel closures. Additionally, adjustments were made to related contracts and interfaces to align with these new methods.

Changes

Files	Change Summary
contracts/core/Dispatcher.sol, contracts/interfaces/IDispatcher.sol, contracts/interfaces/IbcDispatcher.sol	Refactored closeIbcChannel into channelCloseInit and channelCloseConfirm to split the closure process.
contracts/core/UniversalChannelHandler.sol, contracts/interfaces/IbcReceiver.sol	Replaced closeChannel and onCloseIbcChannel with onChanCloseInit and onChanCloseConfirm, updating logic and parameters.
contracts/examples/Mars.sol	Updated channel closure functions and packet handling logic.
test/upgradeableProxy/upgrades/DispatcherV2.sol	Encoded arguments, modified function calls, and introduced new channel closure functions.
test/universal.channel.t.sol	Added test functions for upgrading the Universal Channel Handler.

Possibly related issues

• Refactor openIbcChannel and connectIbcChannel to align with IBC standards #22: The refactoring of channel management functions in this PR mirrors the objectives of splitting channel opening functions for clarity and modularity.
• open-ibc/ibc-sdk#59: Although focused on channel creation, the enhancements in modularity and clarity in channel management could indirectly support the broader goal of improving inter-chain communication as mentioned in this issue.

🐇✨🌟
In the land of code and smart contracts vast,
A rabbit hopped, making changes fast.
Channels close in two hops, not one,
Ensuring all is clear before the job's done.
Celebrate the refactor, oh what a blast!
🌟✨🐇

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 24eefb9 and bf6114e.

Files selected for processing (2)

• contracts/core/UniversalChannelHandler.sol (3 hunks)
• test/universal.channel.t.sol (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• contracts/core/UniversalChannelHandler.sol

Additional comments not posted (2)

test/universal.channel.t.sol (2)

248-261: LGTM! The upgrade test for the Universal Channel Handler is implemented correctly.

---

263-271: LGTM! The test correctly ensures that non-owners cannot perform upgrades on the Universal Channel Handler.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[dshiell]

just a few questions otherwise, i think it looks good