feat: Support Returning Error Resolutions from Providers #323
+78
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrfwow
changed the title
chrfwow
changed the title
Signed-off-by: christian.lutnik <[email protected]>
chrfwow
changed the title
toddbaert
requested review from
cdonnellytx,
benjiro,
kinyoklion,
austindrenski,
toddbaert and
askpt
askpt
reviewed
Nov 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 85.75% 85.91% +0.15%
==========================================
Files 34 34
Lines 1362 1377 +15
Branches 147 148 +1
==========================================
+ Hits 1168 1183 +15
Misses 162 162
Partials 32 32 ☔ View full report in Codecov by Sentry. |
aepfli
approved these changes
Dec 3, 2024
askpt
approved these changes
Dec 3, 2024
arttonoyan
pushed a commit
to arttonoyan/dotnet-sdk
that referenced
this pull request
Dec 4, 2024
…e#323) When provider resolutions with error code set other than `None` are returned, the provider acts as if an error was thrown. Signed-off-by: christian.lutnik <[email protected]> Signed-off-by: Artyom Tonoyan <[email protected]>
askpt
pushed a commit
that referenced
this pull request
Dec 4, 2024
When provider resolutions with error code set other than `None` are returned, the provider acts as if an error was thrown. Signed-off-by: christian.lutnik <[email protected]> Signed-off-by: André Silva <[email protected]>
chrfwow
added a commit
to chrfwow/dotnet-sdk
that referenced
this pull request
Dec 5, 2024
…-feature#323) Signed-off-by: christian.lutnik <[email protected]>
toddbaert
pushed a commit
that referenced
this pull request
Dec 12, 2024
🤖 I have created a release *beep* *boop* --- ## [2.2.0](v2.1.0...v2.2.0) (2024-12-12) ### ✨ New Features * Feature Provider Enhancements- [#321](#321) ([#324](#324)) ([70f847b](70f847b)) * Implement Tracking in .NET [#309](#309) ([#327](#327)) ([cbf4f25](cbf4f25)) * Support Returning Error Resolutions from Providers ([#323](#323)) ([bf9de4e](bf9de4e)) ### 🧹 Chore * **deps:** update dependency fluentassertions to v7 ([#325](#325)) ([35cd77b](35cd77b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #307
How to test
test/OpenFeature.Tests/OpenFeatureClientTests#When_Error_Is_Returned_From_Provider_Should_Not_Run_After_Hook_But_Error_Hookverifies the behaviour