Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Dependency Injection and Hosting support #318

Closed
wants to merge 1 commit into from
Closed

Conversation

toddbaert
Copy link
Member

temp

@toddbaert toddbaert requested a review from a team as a code owner November 18, 2024 13:58
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 46.69421% with 129 lines in your changes missing coverage. Please review.

Project coverage is 85.75%. Comparing base (ccf0250) to head (0054f91).

Files with missing lines Patch % Lines
...ependencyInjection/OpenFeatureBuilderExtensions.cs 43.51% 71 Missing and 3 partials ⚠️
...njection/OpenFeatureServiceCollectionExtensions.cs 54.54% 14 Missing and 1 partial ⚠️
...dencyInjection/Internal/FeatureLifecycleManager.cs 62.50% 8 Missing and 1 partial ⚠️
...ction/Providers/Memory/FeatureBuilderExtensions.cs 0.00% 9 Missing ⚠️
...nFeature.DependencyInjection/OpenFeatureOptions.cs 58.82% 6 Missing and 1 partial ⚠️
src/OpenFeature.DependencyInjection/Guard.cs 25.00% 5 Missing and 1 partial ⚠️
...nFeature.DependencyInjection/OpenFeatureBuilder.cs 64.70% 4 Missing and 2 partials ⚠️
...ection/Providers/Memory/InMemoryProviderFactory.cs 0.00% 2 Missing ⚠️
...enFeature.DependencyInjection/PolicyNameOptions.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
- Coverage   94.19%   85.75%   -8.45%     
==========================================
  Files          25       34       +9     
  Lines        1120     1362     +242     
  Branches      123      147      +24     
==========================================
+ Hits         1055     1168     +113     
- Misses         42      162     +120     
- Partials       23       32       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@toddbaert toddbaert marked this pull request as draft November 18, 2024 14:00
@toddbaert toddbaert closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants