Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Change dotnet formatter #260

Merged
merged 6 commits into from
Apr 11, 2024
Merged

ci: Change dotnet formatter #260

merged 6 commits into from
Apr 11, 2024

Conversation

askpt
Copy link
Member

@askpt askpt commented Apr 10, 2024

This PR

Notes

  • We should now use this tool since it is now shipped as part of the dotnet SDK, removing the need to install an external one.
  • As pointed out in the chat, this build runs in parallel and is relatively fast. I will enable all PRs instead of those focusing on changes to .cs files.

@askpt askpt force-pushed the askpt/change-formatter branch 2 times, most recently from a684e10 to 5edb13a Compare April 11, 2024 07:42
askpt added 2 commits April 11, 2024 08:45
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
@askpt askpt force-pushed the askpt/change-formatter branch from 5edb13a to 025bc33 Compare April 11, 2024 07:46
@askpt askpt marked this pull request as ready for review April 11, 2024 07:49
@askpt askpt requested a review from a team as a code owner April 11, 2024 07:49
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.40%. Comparing base (11a0333) to head (26c6dd7).
Report is 1 commits behind head on main.

❗ Current head 26c6dd7 differs from pull request most recent head 1343a3c. Consider uploading reports for the commit 1343a3c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #260   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          27       27           
  Lines        1111     1111           
  Branches      120      120           
=======================================
  Hits         1060     1060           
  Misses         34       34           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@askpt askpt merged commit d2f08cd into main Apr 11, 2024
11 checks passed
@askpt askpt deleted the askpt/change-formatter branch April 11, 2024 16:19
arttonoyan pushed a commit to arttonoyan/dotnet-sdk that referenced this pull request Nov 17, 2024
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

- This PR changes the code formatter we currently use to the new
built-in in the SDK. See
https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-format

### Notes
- We should now use this tool since it is now shipped as part of the
dotnet SDK, removing the need to install an external one.
- As pointed out in the chat, this build runs in parallel and is
relatively fast. I will enable all PRs instead of those focusing on
changes to .cs files.

---------

Signed-off-by: André Silva <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Artyom Tonoyan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants