refactor: Add TFMs for net{6,7,8}.0 #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 23 23
Lines 931 931
Branches 93 93
=======================================
Hits 882 882
Misses 29 29
Partials 20 20 ☔ View full report in Codecov by Sentry. |
austindrenski
force-pushed
the
add-tfms-for-net6.0-net7.0-net8.0
branch
from
a6b1faa to
1be951d
Compare
benjiro
reviewed
Jan 11, 2024
There was a problem hiding this comment.
I'm fine with this probably a bigger question currently we aren't really using any features above .netstandard2.0 so targeting net6,7,8 is really pointless because there is no runtime benefit. I guess in the future we can look at optimisations and utilize some of the new runtime feature were available
benjiro
approved these changes
Jan 14, 2024
toddbaert
approved these changes
Jan 15, 2024
Fixes: open-feature#160, open-feature#169 Signed-off-by: Austin Drenski <[email protected]>
austindrenski
force-pushed
the
add-tfms-for-net6.0-net7.0-net8.0
branch
from
1be951d to
f93659a
Compare
arttonoyan
pushed a commit
to arttonoyan/dotnet-sdk
that referenced
this pull request
Nov 17, 2024
Signed-off-by: Austin Drenski <[email protected]> Signed-off-by: Artyom Tonoyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a consumer of the OpenFeature SDK, I want
OpenFeature.dllto be built and tested against all of the supported TFMs that my projects might encounter in the wild.This PR:
global.jsonto8.0.1007.0.xto instead resolve based onglobal.jsonnet6.0,net7.0, andnet8.0net6.0is EOL in2024-11-12net7.0is EOL in2024-05-14Fixes: #160, #169