use WriteAsync to write to channel

Signed-off-by: Florian Bacher <[email protected]>
open-feature · Jan 3, 2024 · dc27b0c · dc27b0c
1 parent 2541880
commit dc27b0c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/OpenFeature/EventExecutor.cs b/src/OpenFeature/EventExecutor.cs
@@ -137,7 +137,7 @@ private void StartListeningAndShutdownOld(FeatureProviderReference newProvider,
                 var channel = oldProvider.Provider.GetEventChannel();
                 if (channel != null)
                 {
-                    channel.Writer.TryWrite(new ShutdownSignal());
+                    channel.Writer.WriteAsync(new ShutdownSignal());
                 }
             }
         }
@@ -205,7 +205,7 @@ private async Task ProcessFeatureProviderEventsAsync(FeatureProviderReference pr
                 switch (item)
                 {
                     case ProviderEventPayload eventPayload:
-                        this.EventChannel.Writer.TryWrite(new Event { Provider = providerRef, EventPayload = eventPayload });
+                        this.EventChannel.Writer.WriteAsync(new Event { Provider = providerRef, EventPayload = eventPayload });
                         break;
                     case ShutdownSignal _:
                         providerRef.ShutdownSemaphore.Release();
@@ -264,7 +264,7 @@ private async Task ProcessEventAsync()
         public async Task SignalShutdownAsync()
         {
             // Enqueue a shutdown signal
-            this.EventChannel.Writer.TryWrite(new ShutdownSignal());
+            this.EventChannel.Writer.WriteAsync(new ShutdownSignal());
 
             // Wait for the processing loop to acknowledge the shutdown
             await this._shutdownSemaphore.WaitAsync().ConfigureAwait(false);

diff --git a/test/OpenFeature.Tests/OpenFeatureEventTests.cs b/test/OpenFeature.Tests/OpenFeatureEventTests.cs
@@ -51,6 +51,9 @@ public async Task API_Level_Event_Handlers_Should_Be_Registered()
             eventHandler.Invoke(Arg.Any<ProviderEventPayload>());
 
             Api.Instance.AddHandler(ProviderEventTypes.ProviderReady, eventHandler);
+            Api.Instance.AddHandler(ProviderEventTypes.ProviderConfigurationChanged, eventHandler);
+            Api.Instance.AddHandler(ProviderEventTypes.ProviderError, eventHandler);
+            Api.Instance.AddHandler(ProviderEventTypes.ProviderStale, eventHandler);
 
             var testProvider = new TestProvider();
             await Api.Instance.SetProvider(testProvider);

diff --git a/test/OpenFeature.Tests/TestImplementations.cs b/test/OpenFeature.Tests/TestImplementations.cs
@@ -90,13 +90,13 @@ public override ProviderStatus GetStatus()
         public override Task Initialize(EvaluationContext context)
         {
             this._status = ProviderStatus.Ready;
-            this.EventChannel.Writer.TryWrite(new ProviderEventPayload { Type = ProviderEventTypes.ProviderReady, ProviderName = this.GetMetadata().Name });
+            this.EventChannel.Writer.WriteAsync(new ProviderEventPayload { Type = ProviderEventTypes.ProviderReady, ProviderName = this.GetMetadata().Name });
             return base.Initialize(context);
         }
 
         internal void SendEvent(ProviderEventTypes eventType)
         {
-            this.EventChannel.Writer.TryWrite(new ProviderEventPayload { Type = eventType, ProviderName = this.GetMetadata().Name });
+            this.EventChannel.Writer.WriteAsync(new ProviderEventPayload { Type = eventType, ProviderName = this.GetMetadata().Name });
         }
     }
 }