Added some conditions.

Signed-off-by: André Silva <[email protected]>
open-feature · Feb 2, 2024 · c1ae332 · c1ae332
1 parent cdb8a86
commit c1ae332
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/src/OpenFeature/Model/BaseMetadata.cs b/src/OpenFeature/Model/BaseMetadata.cs
@@ -56,7 +56,6 @@ internal BaseMetadata() : this([])
     /// </summary>
     /// <param name="key">The key of the value to retrieve.</param>
     /// <returns>The string value associated with the key, or null if the key is not found.</returns>
-    /// <exception cref="InvalidCastException">Thrown when the value cannot be cast to a string.</exception>
     public virtual string? GetString(string key)
     {
         var hasValue = this._metadata.TryGetValue(key, out var value);
@@ -65,7 +64,7 @@ internal BaseMetadata() : this([])
             return null;
         }
 
-        return value as string ?? throw new InvalidCastException($"Cannot cast {value?.GetType()} to {typeof(string)}");
+        return value as string ?? null;
     }
 
     private T? GetValue<T>(string key) where T : struct
@@ -76,6 +75,6 @@ internal BaseMetadata() : this([])
             return null;
         }
 
-        return value is T tValue ? tValue : throw new InvalidCastException($"Cannot cast {value?.GetType()} to {typeof(T)}");
+        return value is T tValue ? tValue : null;
     }
 }
diff --git a/test/OpenFeature.Tests/FlagMetadataTest.cs b/test/OpenFeature.Tests/FlagMetadataTest.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using OpenFeature.Model;
+using OpenFeature.Tests.Internal;
 using Xunit;
 
 #nullable enable
@@ -9,6 +10,8 @@ namespace OpenFeature.Tests;
 public class FlagMetadataTest
 {
     [Fact]
+    [Specification("1.4.14",
+        "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]
     public void GetBool_Should_Return_Null_If_Key_Not_Found()
     {
         // Arrange
@@ -22,6 +25,8 @@ public void GetBool_Should_Return_Null_If_Key_Not_Found()
     }
 
     [Fact]
+    [Specification("1.4.14",
+        "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]
     public void GetBool_Should_Return_Value_If_Key_Found()
     {
         // Arrange
@@ -41,6 +46,8 @@ public void GetBool_Should_Return_Value_If_Key_Found()
     }
 
     [Fact]
+    [Specification("1.4.14",
+        "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]
     public void GetBool_Should_Throw_Value_Is_Invalid()
     {
         // Arrange
@@ -61,6 +68,8 @@ public void GetBool_Should_Throw_Value_Is_Invalid()
     }
 
     [Fact]
+    [Specification("1.4.14",
+        "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]
     public void GetInt_Should_Return_Null_If_Key_Not_Found()
     {
         // Arrange
@@ -74,6 +83,8 @@ public void GetInt_Should_Return_Null_If_Key_Not_Found()
     }
 
     [Fact]
+    [Specification("1.4.14",
+        "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]
     public void GetInt_Should_Return_Value_If_Key_Found()
     {
         // Arrange
@@ -94,6 +105,8 @@ public void GetInt_Should_Return_Value_If_Key_Found()
     }
 
     [Fact]
+    [Specification("1.4.14",
+        "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]
     public void GetInt_Should_Throw_Value_Is_Invalid()
     {
         // Arrange
@@ -114,6 +127,8 @@ public void GetInt_Should_Throw_Value_Is_Invalid()
     }
 
     [Fact]
+    [Specification("1.4.14",
+        "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]
     public void GetDouble_Should_Return_Null_If_Key_Not_Found()
     {
         // Arrange
@@ -127,6 +142,8 @@ public void GetDouble_Should_Return_Null_If_Key_Not_Found()
     }
 
     [Fact]
+    [Specification("1.4.14",
+        "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]
     public void GetDouble_Should_Return_Value_If_Key_Found()
     {
         // Arrange
@@ -147,6 +164,8 @@ public void GetDouble_Should_Return_Value_If_Key_Found()
     }
 
     [Fact]
+    [Specification("1.4.14",
+        "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]
     public void GetDouble_Should_Throw_Value_Is_Invalid()
     {
         // Arrange
@@ -167,6 +186,8 @@ public void GetDouble_Should_Throw_Value_Is_Invalid()
     }
 
     [Fact]
+    [Specification("1.4.14",
+        "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]
     public void GetString_Should_Return_Null_If_Key_Not_Found()
     {
         // Arrange
@@ -180,6 +201,8 @@ public void GetString_Should_Return_Null_If_Key_Not_Found()
     }
 
     [Fact]
+    [Specification("1.4.14",
+        "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]
     public void GetString_Should_Return_Value_If_Key_Found()
     {
         // Arrange
@@ -200,6 +223,8 @@ public void GetString_Should_Return_Value_If_Key_Found()
     }
 
     [Fact]
+    [Specification("1.4.14",
+        "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]
     public void GetString_Should_Throw_Value_Is_Invalid()
     {
         // Arrange