refactor: Use ValueTask on plumbing methods #178
austindrenskici.yml
on: pull_request
unit-tests-linux
2m 0s
unit-tests-windows
4m 50s
Annotations
20 errors
|
OpenFeature.Tests.OpenFeatureHookTests.Error_Occurs_During_Before_After_Evaluation_Should_Not_Invoke_Any_Remaining_Hooks:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L413
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task`1 for Hook.BeforeAsync (expected type ValueTask`1).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.When_Error_Occurs_In_Before_Hook_Should_Return_Default_Value:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L488
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task`1 for Hook.BeforeAsync (expected type ValueTask`1).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.When_Error_Occurs_In_After_Hook_Should_Invoke_Error_Hook:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L531
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task for Hook.AfterAsync (expected type ValueTask).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.Error_Occurs_During_Before_After_Evaluation_Should_Not_Invoke_Any_Remaining_Hooks:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L413
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task`1 for Hook.BeforeAsync (expected type ValueTask`1).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.When_Error_Occurs_In_Before_Hook_Should_Return_Default_Value:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L488
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task`1 for Hook.BeforeAsync (expected type ValueTask`1).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.When_Error_Occurs_In_After_Hook_Should_Invoke_Error_Hook:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L531
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task for Hook.AfterAsync (expected type ValueTask).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.Error_Occurs_During_Before_After_Evaluation_Should_Not_Invoke_Any_Remaining_Hooks:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L413
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task`1 for Hook.BeforeAsync (expected type ValueTask`1).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.When_Error_Occurs_In_Before_Hook_Should_Return_Default_Value:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L488
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task`1 for Hook.BeforeAsync (expected type ValueTask`1).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.When_Error_Occurs_In_After_Hook_Should_Invoke_Error_Hook:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L531
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task for Hook.AfterAsync (expected type ValueTask).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
unit-tests-linux
Process completed with exit code 1.
|
|
OpenFeature.Tests.OpenFeatureHookTests.Error_Occurs_During_Before_After_Evaluation_Should_Not_Invoke_Any_Remaining_Hooks:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L413
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task`1 for Hook.BeforeAsync (expected type ValueTask`1).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.When_Error_Occurs_In_Before_Hook_Should_Return_Default_Value:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L488
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task`1 for Hook.BeforeAsync (expected type ValueTask`1).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.When_Error_Occurs_In_After_Hook_Should_Invoke_Error_Hook:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L531
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task for Hook.AfterAsync (expected type ValueTask).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.Error_Occurs_During_Before_After_Evaluation_Should_Not_Invoke_Any_Remaining_Hooks:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L413
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task`1 for Hook.BeforeAsync (expected type ValueTask`1).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.When_Error_Occurs_In_Before_Hook_Should_Return_Default_Value:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L488
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task`1 for Hook.BeforeAsync (expected type ValueTask`1).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.When_Error_Occurs_In_After_Hook_Should_Invoke_Error_Hook:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L531
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task for Hook.AfterAsync (expected type ValueTask).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.Error_Occurs_During_Before_After_Evaluation_Should_Not_Invoke_Any_Remaining_Hooks:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L413
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task`1 for Hook.BeforeAsync (expected type ValueTask`1).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.When_Error_Occurs_In_Before_Hook_Should_Return_Default_Value:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L488
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task`1 for Hook.BeforeAsync (expected type ValueTask`1).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.When_Error_Occurs_In_After_Hook_Should_Invoke_Error_Hook:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L531
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task for Hook.AfterAsync (expected type ValueTask).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|
|
OpenFeature.Tests.OpenFeatureHookTests.Error_Occurs_During_Before_After_Evaluation_Should_Not_Invoke_Any_Remaining_Hooks:
test/OpenFeature.Tests/OpenFeatureHookTests.cs#L414
NSubstitute.Exceptions.CouldNotSetReturnDueToTypeMismatchException : Can not return value of type Task`1 for Hook.BeforeAsync (expected type ValueTask`1).
Make sure you called Returns() after calling your substitute (for example: mySub.SomeMethod().Returns(value)),
and that you are not configuring other substitutes within Returns() (for example, avoid this: mySub.SomeMethod().Returns(ConfigOtherSub())).
If you substituted for a class rather than an interface, check that the call to your substitute was on a virtual/abstract member.
Return values cannot be configured for non-virtual/non-abstract members.
Correct use:
mySub.SomeMethod().Returns(returnValue);
Potentially problematic use:
mySub.SomeMethod().Returns(ConfigOtherSub());
Instead try:
var returnValue = ConfigOtherSub();
mySub.SomeMethod().Returns(returnValue);
|