Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove Microsoft.Extensions.Logging from flagd provider #233

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix: remove Microsoft.Extensions.Logging from flagd provider #233

merged 1 commit into from
Jul 16, 2024

Conversation

ghelyar
Copy link
Contributor

@ghelyar ghelyar commented Jul 15, 2024

This PR

  • Remove Microsoft.Extensions.Logging dependencies from OpenFeature.Contrib.Providers.Flagd
  • Use SemVersion.TryParse to avoid a throw and catch

Related Issues

Fixes #232

@ghelyar ghelyar requested review from a team as code owners July 15, 2024 15:53
@toddbaert
Copy link
Member

I'll review this later today.

@toddbaert
Copy link
Member

@ghelyar nice. Approving, merging and releasing.

I've also updated this issue, which has to do with some (more important) logging: #226

@toddbaert toddbaert merged commit 7385735 into open-feature:main Jul 16, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Jul 16, 2024
Merged
@toddbaert
Copy link
Member

released: #235, https://github.com/open-feature/dotnet-sdk-contrib/releases/tag/OpenFeature.Contrib.Providers.Flagd-v0.2.1

@ghelyar ghelyar deleted the flagd-remove-mel branch July 17, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@bacherfl bacherfl Awaiting requested review from bacherfl

@toddbaert toddbaert Awaiting requested review from toddbaert

Assignees

@bacherfl bacherfl

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flagd dependencies on Microsoft.Extensions.Logging
4 participants
@ghelyar @toddbaert @beeme1mr @bacherfl