-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the fmc card's output clock #295
Conversation
jonnew
commented
Sep 12, 2024
- The user can now create a divided copy of the acquisition clock to sychronize ONIX with external hardware
- The hardware actualized parameters of this clock are made available in the BreakoutBoardClockData class
- Fixes Implement the Breakout board's output clock #277
- The user can now create a divided copy of the acquisition clock to sychronize ONIX with external hardware - The hardware actualized parameters of this clock are made availalbe in the BreakoutBoardClockData class
- Constrain frequency and duty cycle with exceptions - Remove unsafe designation from BreakoutOutputClockData.Generate() - Lots of XML improvments - Improve public property names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good, but there a couple questions that should be addressed before merging. The rest are spelling fixes and updating comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purely from the standpoint of docs and looking at XML comments, I think that this is ready to merge after resolving these and Brandon's comments.
I did not look at the code at all though.
- Rmove "Breakout" prefix from class names (this information is included through the BreakoutBoard MultiDeviceFactory when used in that context) - Lots of typo fixes - Fixed the agruements to OutpuClockParameters such that floating point arthmetic is used so we dont loose precision