Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose headstage port status data stream #216

Closed
wants to merge 1 commit into from
Closed

Expose headstage port status data stream #216

wants to merge 1 commit into from

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Aug 14, 2024

  • Fixes Use FMC Link Controller data stream  #156
  • I feel that FmcLinkController and ConfigureFmcLinkController should be renamed PortController and ConfigurePortController, respectively to match their implicity configurate via the "Port" property in headstages and miniscopes, as well as their labelling on the hardware

@jonnew
Expose headstage port status data stream
9724fd1 
- Fixes #156
- I feel that FmcLinkController  and ConfigureFmcLinkController should be renamed PortController and ConfigurePortController, respectively to match their implicity configurate via the "Port" property in headstages and miniscopes, as well as their labelling on the hardware
@jonnew jonnew requested a review from glopesdev August 14, 2024 22:47
jonnew
jonnew commented Aug 14, 2024
View reviewed changes
OpenEphys.Onix1/ConfigureNeuropixelsV2eLinkController.cs
@@ -29,7 +29,7 @@ protected override bool ConfigurePortVoltage(DeviceContext device)

void SetVoltage(DeviceContext device, double voltage)
{
device.WriteRegister(FmcLinkController.PORTVOLTAGE, 0);
device.WriteRegister(PortController.PORTVOLTAGE, 0);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mistake. I tried to leave this change for the discussion and instead broke the code.

@jonnew jonnew closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glopesdev glopesdev Awaiting requested review from glopesdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use FMC Link Controller data stream
1 participant
@jonnew