Convert BreakoutAnalogOutput data to offset binary #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonnew
commented
Aug 13, 2024
•
jonnew
commented
- Fixes Incorrect data type for BreakoutAnalogOutput #205
- The analog outputs on the breakout board expect 16-bit words in offset binary
- We were using twos-complement. This fix converts all outgoing data to offset binary before the final calls to device.Write()
- The analog outputs on the breakout board expect 16-bit words in offset binary - We were using twos-complement. This fix converts all outgoing data to offset binary before the final calls to device.Write()
|
To automatically close the existing issue, we can link it from the PR back to the issue with closing language. For example: It looks like this language needs to be in the original comment to link the issues correctly. |
jonnew
commented
Aug 20, 2024
| @@ -108,6 +115,12 @@ public IObservable<short[]> Process(IObservable<short[]> source) | |||
| return source.Do(data => | |||
| { | |||
| AssertChannelCount(data.Length); | |||
| var samples = new ushort[data.Length]; | |||
There was a problem hiding this comment.
There is potentially an opencv operation that would vectorize this. cv.xors is what we should look into.
- Tested in hardware appears to work well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.