Skip to content

Commit

Permalink
Address code review
Browse files Browse the repository at this point in the history
- I want to wait to merge until the parallel refactor of gain and adc
calibration file parsing is done so I can make use of that.
  • Loading branch information
jonnew committed Sep 5, 2024
1 parent efe130e commit 53d2b31
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 11 deletions.
23 changes: 14 additions & 9 deletions OpenEphys.Onix1/ConfigureHeadstageNric1384.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,25 @@
namespace OpenEphys.Onix1
{
/// <summary>
/// A class that configures a Nric1384 headstage on the specified port.
/// Configures a Nric1384 headstage on the specified port.
/// </summary>
/// <remarks>
/// Headstage-Nric1384 is a 2.5g serialized, multifunction headstage for small animals built around the IMEC Nric1384 bioacquisition chip.
/// This headstage is designed to function with passive probes of the user's choosing (e.g. silicon probe arrays, high-density
/// tetrode drives, etc). It provides the following features:
/// The Nric1384 Headstage is a 2.5g serialized, multifunction headstage for small animals built around the
/// IMEC Nric1384 bioacquisition chip. This headstage is designed to function with passive probes of the
/// user's choosing (e.g. silicon probe arrays, high-density tetrode drives, etc). It provides the
/// following features:
/// <list type="bullet">
/// <item><description>384 analog ephys channels sampled at 30 kHz per channel and exposed via an array of 12x ultra-high density Molex 203390-0323 quad-row connectors. </description></item>
/// <item><description>A BNO055 9-axis IMU for real-time, 3D orientation tracking at 100 Hz.</description></item>
/// <item><description>Two TS4231 light to digital converters for real-time, 3D position tracking with HTC Vive base stations.</description></item>
/// <item><description>A single electrical stimulator (current controlled, +/-15V compliance, automatic electrode discharge).</description></item>
/// <item><description>384 analog ephys channels sampled at 30 kHz per channel and exposed via an array of
/// 12x ultra-high density Molex 203390-0323 quad-row connectors. </description></item>
/// <item><description>A BNO055 9-axis IMU for real-time, 3D orientation tracking at 100
/// Hz.</description></item>
/// <item><description>Two TS4231 light to digital converters for real-time, 3D position tracking with HTC
/// Vive base stations.</description></item>
/// <item><description>A single electrical stimulator (current controlled, +/-15V compliance, automatic
/// electrode discharge).</description></item>
/// </list>
/// </remarks>
[Description("Configures a NeuropixelsV1e headstage.")]
[Description("Configures a Nric1384 Headstage headstage.")]
public class ConfigureHeadstageNric1384 : MultiDeviceFactory
{
PortName port;
Expand Down
2 changes: 1 addition & 1 deletion OpenEphys.Onix1/ConfigureNric1384.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace OpenEphys.Onix1
{
/// <summary>
/// A class that configures a Nric184 bioacquisition device.
/// Configures a Nric184 bioacquisition device.
/// </summary>
public class ConfigureNric1384 : SingleDeviceFactory
{
Expand Down
1 change: 0 additions & 1 deletion OpenEphys.Onix1/Nric1384RegisterContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,6 @@ public void WriteShiftRegisters()

for (int j = 0; j < 2; j++)
{

var baseBytes = BitArrayToBytes(BaseConfigs[i]);

WriteByte(Nric1384.SR_LENGTH1, (uint)baseBytes.Length % 0x100);
Expand Down

0 comments on commit 53d2b31

Please sign in to comment.