Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularize API and code review #9

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Modularize API and code review #9

merged 3 commits into from
Aug 14, 2024

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Aug 14, 2024

  • Break the classes contained with the large ProbeInterface class into standalone files
  • Remove autogenated backing fields and cruft
  • Some sytanx changes and simplifications

@jonnew
Modularize API and code review
4110ce0 
- Break the classes contained with the large ProbeInterface class into
  standalone files
- Remove autogenated backing fields and cruft
- Some sytanx changes and simplifications
@jonnew jonnew requested a review from bparks13 August 14, 2024 17:31
bparks13
bparks13 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@bparks13 bparks13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! Everything looks really good split out and cleaned up. I fixed some residual whitespace issues, but I have no major changes to add. Tested this with OpenEphys.Onix1 and everything seems to be fully functional.

@jonnew jonnew merged commit eb79f0c into main Aug 14, 2024
7 checks passed
@bparks13 bparks13 deleted the jon-review branch August 14, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparks13 bparks13 bparks13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonnew @bparks13