-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extension_explorer/templates/publishers.html: Integrate content from … #84
Conversation
…extension template
Just checking what makes this PR a draft? |
Pull Request Test Coverage Report for Build 11730318943Details
💛 - Coveralls |
Oops, I somehow missed the notification about your comment. Sorry! It was draft because I needed to resolve the pytest failure. I've done that now. As well as integrating the content from how the extensions work I think that we should also integrate the content from codelists. Otherwise, the explanations of schema extensions and codelist extensions will be in different places. I've rewritten the codelist explanation to follow the same style as the schema guidance:
Shall I add that to this PR? |
Oh, I forgot that open-contracting/standard_extension_template#41 is about moving all the content. I may as well do it all in this PR, but I'll prepare a draft in Google Docs before updating the HTML templates. |
Logging the steps I followed so far, for posterity:
To-do:
|
@jpmckinney the lint check is failing because ruff reports errors on Python files not touched by this PR. |
Needed to merge |
Ah, I forgot this was an old branch. Thanks! |
Leaving as draft pending further input on the needs of extension authors in open-contracting/standard_extension_template#41. Otherwise, this is ready for review. |
…avoid weird whitespace in translatable strings
…re margins in numbered list.
I think we might as well get this PR done and make other changes/improvements later. @yolile I pushed strings to Transifex: https://app.transifex.com/open-contracting-partnership-1/ocds-extension-explorer/translate/#es/messages/306008985 |
Translated |
Closes open-contracting/standard_extension_template#41