Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose any errors that occur while expanding onto a new subnet #7094

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Expose any errors that occur while expanding onto a new subnet #7094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9753e07
Expose any errors that occur while expanding onto a new subnet
hpeebles Dec 19, 2024
3d44ab4
Update CHANGELOG
hpeebles Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions backend/canisters/registry/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## [unreleased]

### Changed

- Expose any errors that occur while expanding onto a new subnet ([#7094](https://github.com/open-chat-labs/open-chat/pull/7094))

## [[2.0.1536](https://github.com/open-chat-labs/open-chat/releases/tag/v2.0.1536-registry)] - 2024-12-19

### Fixed
Expand Down
3 changes: 2 additions & 1 deletion backend/canisters/registry/impl/src/timer_job_types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ use ic_cdk::api::call::{CallResult, RejectionCode};
use ic_cdk::api::management_canister::main::{CanisterSettings, UpdateSettingsArgument};
use ic_ledger_types::{AccountIdentifier, Memo, Subaccount, Timestamp, Tokens, TransferArgs, DEFAULT_FEE};
use serde::{Deserialize, Serialize};
use tracing::error;
use types::{CanisterId, TimestampMillis};

const MEMO_CREATE_CANISTER: Memo = Memo(0x41455243); // == 'CREA'
Expand Down Expand Up @@ -54,7 +55,7 @@ impl ExpandOntoSubnetJob {
let delay = match self.process_step_inner(next_step, now).await {
Ok(Some(false)) => 0,
Err(error) => {
ic_cdk::println!("ExpandOntoSubnet processing failed: {:?}", error);
error!("ExpandOntoSubnet processing failed: {:?}", error);
MINUTE_IN_MS
}
Ok(Some(true)) | Ok(None) => return,
Expand Down
Loading