Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't render the menu unless we are in the viewport #5045

Merged
merged 5 commits into from
Dec 19, 2023
Merged

don't render the menu unless we are in the viewport #5045

merged 5 commits into from
Dec 19, 2023

Conversation

julianjelfs
Copy link
Collaborator

I would like to understand a bit better why this makes such a difference, but it's definitely worth doing.

@julianjelfs julianjelfs merged commit 2e35ca7 into master Dec 19, 2023
7 checks passed
@julianjelfs julianjelfs deleted the performance branch December 19, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpeebles hpeebles hpeebles approved these changes

@megrogan megrogan Awaiting requested review from megrogan megrogan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianjelfs @hpeebles