Rename 'block_index' to 'transaction_index'

backend/canisters/registry/CHANGELOG.md

@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### Changed
 
 - Use dynamic buffer size when reading from stable memory ([#4683](https://github.com/open-chat-labs/open-chat/pull/4683))
+- Rename 'block_index' to 'transaction_index' ([#4683](https://github.com/open-chat-labs/open-chat/pull/4683))
 
 ## [[2.0.918](https://github.com/open-chat-labs/open-chat/releases/tag/v2.0.918-registry)] - 2023-10-30
 

backend/canisters/registry/impl/src/lifecycle/post_upgrade.rs

@@ -1,6 +1,6 @@
 use crate::lifecycle::{init_env, init_state};
 use crate::memory::get_upgrades_memory;
-use crate::Data;
+use crate::{mutate_state, Data};
 use canister_logger::LogEntry;
 use canister_tracing_macros::trace;
 use ic_cdk_macros::post_upgrade;
@@ -25,4 +25,6 @@ fn post_upgrade(args: Args) {
     init_state(env, data, args.wasm_version);
 
     info!(version = %args.wasm_version, "Post-upgrade complete");
+
+    mutate_state(|state| state.data.tokens.rename_block_index_to_transaction_index());
 }

backend/canisters/registry/impl/src/model/tokens.rs

@@ -9,6 +9,12 @@ pub struct Tokens {
 }
 
 impl Tokens {
+    pub fn rename_block_index_to_transaction_index(&mut self) {
+        for token in self.tokens.iter_mut() {
+            token.transaction_url_format = token.transaction_url_format.replace("block_index", "transaction_index");
+        }
+    }
+
     #[allow(clippy::too_many_arguments)]
     pub fn add(
         &mut self,

backend/canisters/registry/impl/src/updates/add_token.rs

@@ -132,7 +132,7 @@ fn extract_urls(
             .as_ref()
             .filter(|ns| !ns.is_nns)
             .map(|ns| ns.root_canister_id)
-            .map(|c| format!("https://dashboard.internetcomputer.org/sns/{c}/transaction/{{block_index}}"))
+            .map(|c| format!("https://dashboard.internetcomputer.org/sns/{c}/transaction/{{transaction_index}}"))
     }) {
         Some(url) => url,
         _ => return Err("'transaction_url_format' must be provided for non-SNS tokens"),

frontend/app/src/components/home/profile/AccountTransactions.svelte

@@ -49,7 +49,10 @@
     });
 
     function url(id: bigint): string {
-        return urlFormat.replace("{block_index}", id.toString()).replace("{transaction_hash}", "");
+        return urlFormat
+            .replace("{block_index}", id.toString())
+            .replace("{transaction_index}", id.toString())
+            .replace("{transaction_hash}", "");
     }
 
     function openDashboard(id: bigint) {

frontend/openchat-client/src/utils/chat.ts

@@ -1597,6 +1597,7 @@ export function buildTransactionUrl(
 
     return transactionUrlFormat
         .replace("{block_index}", transfer.blockIndex.toString())
+        .replace("{transaction_index}", transfer.blockIndex.toString())
         .replace("{transaction_hash}", transfer.transactionHash ?? "");
 }