make sure we switch to default route if we remove the last fav (#6824)

frontend/app/src/components/home/Home.svelte

@@ -1035,6 +1035,7 @@
                     role: "owner",
                 },
                 messagesVisibleToNonMembers: false,
+                externalUrl: embeddedContent ? "" : undefined,
             },
         };
     }

frontend/openchat-client/src/liveState.ts

@@ -20,6 +20,7 @@ import type {
     DiamondMembershipStatus,
     ChitState,
     WalletConfig,
+    ObjectSet,
 } from "openchat-shared";
 import { selectedAuthProviderStore } from "./stores/authProviders";
 import {
@@ -49,6 +50,7 @@ import {
     currentChatMembers,
     currentChatRules,
     pinnedChatsStore,
+    favouritesStore,
 } from "./stores/chat";
 import { remainingStorage } from "./stores/storage";
 import { userCreatedStore } from "./stores/userCreated";
@@ -119,6 +121,7 @@ export class LiveState {
     chatListScope!: ChatListScope;
     globalState!: GlobalState;
     pinnedChats!: PinnedByScope;
+    favourites!: ObjectSet<ChatIdentifier>;
     allChats!: ChatMap<ChatSummary>;
     selectedCommunity!: CommunitySummary | undefined;
     currentCommunityMembers!: Map<string, Member>;
@@ -183,6 +186,7 @@ export class LiveState {
         chatListScopeStore.subscribe((scope) => (this.chatListScope = scope));
         globalStateStore.subscribe((data) => (this.globalState = data));
         pinnedChatsStore.subscribe((data) => (this.pinnedChats = data));
+        favouritesStore.subscribe((data) => (this.favourites = data));
         allChats.subscribe((data) => (this.allChats = data));
         selectedCommunity.subscribe((data) => (this.selectedCommunity = data));
         currentCommunityMembers.subscribe((data) => (this.currentCommunityMembers = data));

frontend/openchat-client/src/openchat.ts

@@ -7271,6 +7271,10 @@ export class OpenChat extends OpenChatAgentWorker {
 
     removeFromFavourites(chatId: ChatIdentifier): Promise<boolean> {
         localChatSummaryUpdates.unfavourite(chatId);
+        if (this._liveState.chatSummariesList.length === 0) {
+            this.dispatchEvent(new SelectedChatInvalid());
+        }
+
         return this.sendRequest({ kind: "removeFromFavourites", chatId })
             .then((resp) => {
                 if (resp !== "success") {
@@ -7445,8 +7449,10 @@ export class OpenChat extends OpenChatAgentWorker {
         // However, with communities enabled it is not clear what this means
         // we actually need to direct the user to one of the global scopes "direct", "group" or "favourites"
         // which one we choose is kind of unclear and probably depends on the state
+
         const global = this._liveState.globalState;
-        if (global.favourites.size > 0) return { kind: "favourite" };
+        const favourites = this._liveState.favourites;
+        if (favourites.size > 0) return { kind: "favourite" };
         if (global.groupChats.size > 0) return { kind: "group_chat" };
         return { kind: "direct_chat" };
     }