Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add k8s docs for getting started, K8s Manifest and Helm #179
base: main
Are you sure you want to change the base?
add k8s docs for getting started, K8s Manifest and Helm #179
Changes from 4 commits
44d9c28
8e7f138
fcf8851
12e2e4f
de87a0a
ccf1240
301aeab
d1e61a8
5226689
4bddc94
40a3f03
cb6b75d
da2c2b1
f986377
883d804
a2c98ae
5cd26ff
790bcff
5d62c2d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to provide guidance on the memory/disk requirements for k8s cluster, otherwise ChatQnA may not run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use of "current" in all of these is wrong.
When namespace is not specified, removal is done from "default" namespace, not "current" one, whatever that is.
=> I think all examples should include namespace option,.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the
Create and Set Namespace
above this section to indicate whatcurrent
namespace means.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not clear whether this script is standard for all Helm charts or unique to OPEA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unique to OPEA. Normally one just calls Helm dep command directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we should use the standard tools instead of creating our own mechanisms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm rather new to Helm, so all of this is very much AFAIK:
@poussa ?