Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FineTuning example infra #122

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

xwu99
Copy link
Contributor

@xwu99 xwu99 commented Jun 24, 2024

Description

Infra for adding FineTuning example

Related PRs:
opea-project/GenAIComps#236
opea-project/GenAIExamples#315

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

KfreeZ and others added 2 commits June 24, 2024 05:39
Signed-off-by: KfreeZ <[email protected]>
Signed-off-by: Wu, Xiaochang <[email protected]>
Signed-off-by: Wu, Xiaochang <[email protected]>
@KfreeZ
Copy link
Collaborator

KfreeZ commented Jun 24, 2024

seems this PR has included code changes of #116, looks like a merge or rebase is needed

spec:
containers:
- name: opea-finetune
image: opea-finetune:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the image name correct? Do you mean opea/finetune?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment, It's a draft PR now. I will revise the image name.

name: opea-finetune-entrypoint
namespace: default
spec:
type: NodePort
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If NodePort is not must, please remove it. NodePort will cause conflict in the CI test machine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I will remove that. do you have a port assignment rule for each new microservice?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not much rules. It's better to use a same port as mega service but using ClusterIP to avoid hard coded port number. For your reference: https://github.com/opea-project/GenAIInfra/blob/main/manifests/DocSum/xeon/tgi_service.yaml#L17

@daisy-ycguo
Copy link
Collaborator

@xwu99 Please add e2e test for this workload. You can follow the format of manifest test script to add three functions:
-init_finetune
-install_finetune
-validate_finetune

@xwu99
Copy link
Contributor Author

xwu99 commented Jun 25, 2024

@xwu99 Please add e2e test for this workload. You can follow the format of manifest test script to add three functions: -init_finetune -install_finetune -validate_finetune

thanks, I will follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants