Skip to content

Commit

Permalink
Pre-CI fixes + drop obsolete HPA variable from ChatQnA Chart
Browse files Browse the repository at this point in the history
Variable was left-over from "Fixes for Helm installed Prometheus version".

Signed-off-by: Eero Tamminen <[email protected]>
  • Loading branch information
eero-t committed Sep 10, 2024
1 parent f46f733 commit 7eb3690
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions helm-charts/HPA.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ otherwise adapter cannot access it!

(Alternative for setting the above `prometheusSpec` variable to `false` is making sure that
`prometheusRelease` value in top-level chart matches the release name given to the Prometheus
install i.e. when it differs from `prometheus-stack` used above. That is used to annotate
install i.e. when it differs from `prometheus-stack` used above. That is used to annotate
created serviceMonitors with a label Prometheus requires when above option is `true`.)

## Gotchas
Expand Down Expand Up @@ -97,7 +97,7 @@ To enable HPA, add `-f chatqna/hpa-values.yaml` option to your `helm install` co

If **CPU** versions of TGI (and TEI) services are being scaled, resource requests and probe timings
suitable for CPU usage need to be used. Add `-f chatqna/cpu-values.yaml` option to your `helm install`
line. If you need to change model specified there, update the resource requests accordingly.
line. If you need to change model specified there, update the resource requests accordingly.

### Post-install

Expand Down
1 change: 0 additions & 1 deletion helm-charts/chatqna/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ affinity: {}
# This is just to avoid Helm errors when HPA is NOT used
# (use hpa-values.yaml files to actually enable HPA).
horizontalPodAutoscaler:
configMap: "MISSING"
enabled: false

# Override values in specific subcharts
Expand Down

0 comments on commit 7eb3690

Please sign in to comment.