Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align parameters for "max_token, repetition_penalty,presence_penalty,frequency_penalty" #726

Merged
merged 21 commits into from
Sep 19, 2024

Conversation

XinyaoWa
Copy link
Collaborator

@XinyaoWa XinyaoWa commented Sep 4, 2024

Description

Align with PR in GenAIComps opea-project/GenAIComps#608

  1. Support and clarify the usage for frequency_penalty/presence_penalty/repetition_penalty
  1. Align to max_tokens for LLM
    Comps: LLMs use max_tokens, others use max_new_tokens
    Examples(keep unchanged): Most use max_tokens

Issues

#673

Signed-off-by: Xinyao Wang <[email protected]>
@hshen14 hshen14 requested a review from chensuyue September 4, 2024 03:24
@chensuyue chensuyue added this to the v1.0 milestone Sep 5, 2024
@chensuyue chensuyue removed this from the v1.0 milestone Sep 11, 2024
XinyaoWa and others added 4 commits September 13, 2024 13:41
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
@XinyaoWa XinyaoWa changed the title align max_new_tokens parameters Align parameters for "max_new_token, repetition_penalty,presence_penalty,frequency_penalty" Sep 13, 2024
@XinyaoWa XinyaoWa changed the title Align parameters for "max_new_token, repetition_penalty,presence_penalty,frequency_penalty" Align parameters for "max_token, repetition_penalty,presence_penalty,frequency_penalty" Sep 19, 2024
@lvliang-intel lvliang-intel merged commit 2f03a3a into opea-project:main Sep 19, 2024
23 checks passed
polszewska pushed a commit to polszewska/GenAIExamples that referenced this pull request Sep 20, 2024
…frequency_penalty" (opea-project#726)

Signed-off-by: Xinyao Wang <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@XinyaoWa XinyaoWa deleted the align_param branch November 7, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants