-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align parameters for "max_token, repetition_penalty,presence_penalty,frequency_penalty" #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xinyao Wang <[email protected]>
kevinintel
approved these changes
Sep 5, 2024
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
for more information, see https://pre-commit.ci
XinyaoWa
changed the title
align max_new_tokens parameters
Align parameters for "max_new_token, repetition_penalty,presence_penalty,frequency_penalty"
Sep 13, 2024
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
XinyaoWa
changed the title
Align parameters for "max_new_token, repetition_penalty,presence_penalty,frequency_penalty"
Align parameters for "max_token, repetition_penalty,presence_penalty,frequency_penalty"
Sep 19, 2024
lvliang-intel
approved these changes
Sep 19, 2024
polszewska
pushed a commit
to polszewska/GenAIExamples
that referenced
this pull request
Sep 20, 2024
…frequency_penalty" (opea-project#726) Signed-off-by: Xinyao Wang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Align with PR in GenAIComps opea-project/GenAIComps#608
Comps: LLMs use max_tokens, others use max_new_tokens
Examples(keep unchanged): Most use max_tokens
Issues
#673