-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added compose example for MultimodalQnA deployment on AMD ROCm systems #1233
base: main
Are you sure you want to change the base?
Added compose example for MultimodalQnA deployment on AMD ROCm systems #1233
Conversation
…tems Signed-off-by: artem-astafev <[email protected]>
15ea852
to
95f9b07
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @artem-astafev , thanks for your contribution.
Please check the comment here and refine the set_env part in your readme.
``` | ||
|
||
```bash | ||
export no_proxy=${your_no_proxy} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you already have the 'set_env.sh' script, please use that script here and delete the redundant env settings: 'source ./set_env.sh'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @letonghan,
Done, Environment set part description is changed to run set_env.sh for setting up environment variables.
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Hi @letonghan , I've removed manual environment set part and add set_env.sh description in Readme.md in last 2 commits(c7291ce and 0ecb8b5). I can't get what else can be change in Readme.md for better description. Is these enough or something else need to be changed ? |
CI Tests starts to fail because of backend microservice could start with error:
Probably because of opea-project/GenAIComps#979 merge. |
Signed-off-by: Artem Astafev <[email protected]>
for more information, see https://pre-commit.ci
Description
Changes for MultimodalQnA example deployment to AMD ROCm systems.
Type of change
Tests
For manual test s go to GenAIExamples/MultimodalQnA/tests dir and run test_compose_on_rocm.sh script (./test_compose_on_rocm.sh)