Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compose example for FaqGen AMD ROCm #1126

Conversation

artem-astafev
Copy link
Contributor

Type of change

  • Added compose file for FaqGen AMD ROCm deploy example
  • Added ReadMe for FaqGen AMD ROCm deploy example
  • Added CI tests for aqGen AMD ROCm deployment

Tests

Go to GenAIExamples/FaqGen/tests/ and run test_compose_on_rocm.sh (./test_compose_on_rocm.sh)

Signed-off-by: Artem Astafev <[email protected]>
Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
@artem-astafev
Copy link
Contributor Author

Looks like FaqGen Mega Service return 500 when trying to work with LLM JSON response,

I raised issue for this error: #1132

Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
@artem-astafev artem-astafev force-pushed the add-compose-FaqGen-example-for-amd-rocm branch from 442660f to 44b5736 Compare November 14, 2024 07:59
@joshuayao joshuayao added this to the v1.1 milestone Nov 15, 2024
@joshuayao joshuayao added the feature New feature or request label Nov 15, 2024
@joshuayao joshuayao removed this from the v1.1 milestone Nov 15, 2024
Signed-off-by: Artem Astafev <[email protected]>
@joshuayao joshuayao added this to the v1.2 milestone Nov 15, 2024
Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @chensuyue !!

@chensuyue
Copy link
Collaborator

Please fix the CI issue cause by the megaservice input message format.

@joshuayao joshuayao linked an issue Nov 18, 2024 that may be closed by this pull request
6 tasks
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
@artem-astafev
Copy link
Contributor Author

Please fix the CI issue cause by the megaservice input message format.

@chensuyue Thank you for the tip, CI functional test are completing successfully after message input format replacement.

@chensuyue chensuyue merged commit 5648839 into opea-project:main Nov 18, 2024
12 checks passed
@joshuayao joshuayao modified the milestones: v1.2, v1.1 Nov 18, 2024
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request Nov 21, 2024
Signed-off-by: artem-astafev <[email protected]>
Signed-off-by: Chingis Yundunov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Examples on AMD ROCm for OPEA v1.1
5 participants