Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix left issue of tgi version update #1121

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Fix left issue of tgi version update #1121

merged 5 commits into from
Nov 13, 2024

Conversation

chensuyue
Copy link
Collaborator

@chensuyue chensuyue commented Nov 12, 2024

Description

Fix left issue of tgi version update

Issues

#1088

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: chensuyue <[email protected]>
Copy link

github-actions bot commented Nov 12, 2024

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@chensuyue chensuyue added the WIP label Nov 12, 2024
@Spycsh
Copy link
Member

Spycsh commented Nov 12, 2024

@ctao456 may be more familiar and help with this CI issue (possibly caused by TGI version update). I'll check this when I'm available.

@Spycsh
Copy link
Member

Spycsh commented Nov 12, 2024

requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

From the log it shows that animation-gaudi-server trying to access the wav2lip service container and it fails. I suspect it is because the request is issued before the wav2lip service is up.

@ctao456
Copy link
Contributor

ctao456 commented Nov 13, 2024

@chensuyue will

  1. replace all occurrences of HABANA_VISIBLE_MODULES with HABANA_VISIBLE_DEVICES
  2. add -q flag to wget commands in entrypoint.sh for the wav2lip microservice, so that the download progress lines won't blob the output log
    https://github.com/opea-project/GenAIComps/blob/3b106c82ef9fecf73d92877fef6e19f3004ff46a/comps/animation/wav2lip/dependency/entrypoint.sh#L14-L18

Thanks @Spycsh

@lvliang-intel lvliang-intel merged commit 393367e into main Nov 13, 2024
15 checks passed
@lvliang-intel lvliang-intel deleted the suyue/bug-fix-tgi branch November 13, 2024 07:42
@chensuyue chensuyue removed the WIP label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants