Skip to content

Commit

Permalink
remove continue-on-error: true to stop the test when image build fail…
Browse files Browse the repository at this point in the history
…ed (#608)

Signed-off-by: chensuyue <[email protected]>
  • Loading branch information
chensuyue authored Aug 16, 2024
1 parent c86cf85 commit 6296e9f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/_example-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ on:
default: false
required: false
type: boolean
GenAIComps_branch:
opea_branch:
default: "main"
required: false
type: string
Expand All @@ -42,7 +42,6 @@ jobs:
####################################################################################################
build-images:
runs-on: "docker-build-${{ inputs.node }}"
continue-on-error: true
steps:
- name: Clean Up Working Directory
run: sudo rm -rf ${{github.workspace}}/*
Expand All @@ -61,7 +60,7 @@ jobs:
git clone https://github.com/vllm-project/vllm.git
fi
git clone https://github.com/opea-project/GenAIComps.git
cd GenAIComps && git checkout ${{ inputs.GenAIComps_branch }} && cd ../
cd GenAIComps && git checkout ${{ inputs.opea_branch }} && cd ../
- name: Build Image
if: ${{ fromJSON(inputs.build) }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/manual-example-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ on:
description: 'Test examples with k8s'
required: false
type: boolean
GenAIComps_branch:
opea_branch:
default: "main"
description: 'GenAIComps branch for image build'
description: 'OPEA branch for image build'
required: false
type: string

Expand Down Expand Up @@ -80,5 +80,5 @@ jobs:
scan: ${{ fromJSON(inputs.scan) }}
test_compose: ${{ fromJSON(inputs.test_compose) }}
test_k8s: ${{ fromJSON(inputs.test_k8s) }}
GenAIComps_branch: ${{ inputs.GenAIComps_branch }}
opea_branch: ${{ inputs.opea_branch }}
secrets: inherit

0 comments on commit 6296e9f

Please sign in to comment.