Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Migration to AndroidX #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migration to AndroidX #63

wants to merge 1 commit into from

Conversation

pavel163
Copy link

No description provided.

@raphaelm
Copy link
Member

Hi @pavel163, thank you very much! @johan12345, who is responsible for this library, is currently on vacation and will have a look at this as soon as he's back, so I'd ask you to be patient for bit! :)

@raphaelm raphaelm requested a review from johan12345 December 11, 2018 11:36
@johan12345
Copy link
Contributor

johan12345 commented Dec 22, 2018

It seems that you did update all dependencies and the compileSdkVersion etc., but did not have a look at what changed in the actual design library (now: Material Components Android) code to see what changed in the classes that we needed to copy from them. I will go through this now and update the PR accordingly.
As already mentioned by @PattaFeuFeu in #61, we probably need to copy some additional classes because they now have the @RestrictTo annotations in the library.

@johan12345
Copy link
Contributor

Wow, there's actually a fair amount of changes in the library code and a lot of new classes that we need to copy from the Material Components Library to our library because of the RestrictTo annotations.

I compared the sources of the relevant classes from here:
https://dl.google.com/dl/android/maven2/com/android/support/design/27.1.1/design-27.1.1-sources.jar
to here:
https://dl.google.com/dl/android/maven2/com/google/android/material/material/1.1.0-alpha02/material-1.1.0-alpha02-sources.jar

As Android 9 is starting to enforce these restrictions, there's no way around this if we want to make the library work on Android 9.

I think I'm not really motivated to do this over Christmas, if at all 😒

The much better way would be if the people at Google could finally implement our changes into the Material Components Library directly (see material-components/material-components-android#6)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants