This repository has been archived by the owner on Oct 1, 2020. It is now read-only.
(SIMP-1169) Add RuboCop, fix for failures #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds RuboCop and its Rake task to this repo, as well as to the baseline modulesync configs, and fixes all RuboCop failures. Additionally, for this repo, it adds RuboCop as a Travis-CI test. A few minor changes were made to the RuboCop configuration. Namely, changes were made to maintain compatability with Ruby 1.8.7, because we need to maintain compatability with RHEL/CentOS 5 & 6 until they reach EOL. A few other changes are set to adhere to the Puppet Style Guide where the are conflicts-- for example, line length and end-of-line commas.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds RuboCop and its Rake task to this repo, as well as to the
baseline modulesync configs, and fixes all RuboCop failures.
Additionally, for this repo, it adds RuboCop as a Travis-CI test.
A few minor changes were made to the RuboCop configuration. Namely,
changes were made to maintain compatability with Ruby 1.8.7, because we
need to maintain compatability with RHEL/CentOS 5 & 6 until they reach
EOL. A few other changes are set to adhere to the Puppet Style Guide
where the are conflicts-- for example, line length and end-of-line
commas.