Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1st i18n collaboration #3475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnfelipe
Copy link

Description

Changes have been made to the internationalization message files, specifically in the web/src/messages/en.json file. New translation keys were added for the home page and common UI elements.

How Has This Been Tested?

  • Verified that all translation keys are properly formatted in JSON
  • Confirmed that translations display correctly in the UI
  • Performed integration tests to ensure messages load properly
  • Verified translation consistency across different application contexts

Accepted Risk

N/A

Related Issue(s)

N/A

Mental Checklist:

  • ✅ All of the automated tests pass
  • ✅ All PR comments are addressed and marked resolved
  • ✅ No migrations requiring rebase
  • ✅ No new dependencies added
  • ✅ No new environment variables
  • ✅ No new public endpoints
  • ✅ Docker images build and basic functionalities work
  • ✅ Author has done a final read through of the PR right before merge

Backporting

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Dec 15, 2024

Someone is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant