Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth specific rate limiting #3463

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Auth specific rate limiting #3463

wants to merge 7 commits into from

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Dec 14, 2024

Description

Rate limit auth endpoints

Screenshot 2024-12-16 at 7 06 47 PM

How Has This Been Tested?

For auth type basic, google auth and cloud:

  • Try logging in with and without rate limiting enabled
  • Spam the register / signin with rate limiting enabled and verify the 429.

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

@pablonyx pablonyx changed the title k Updated Tests Dec 14, 2024
Copy link

vercel bot commented Dec 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 3:12am

@pablonyx pablonyx changed the title Lock accounts Auth specific rate limiting Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant