Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent SSRF risk #3453

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Prevent SSRF risk #3453

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b9ccad
update con
pablonyx Dec 12, 2024
d516b8f
k
pablonyx Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions backend/danswer/connectors/web/connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
from danswer.file_processing.html_utils import web_html_cleanup
from danswer.utils.logger import setup_logger
from danswer.utils.sitemap import list_pages_for_site
from shared_configs.configs import MULTI_TENANT

logger = setup_logger()

Expand Down Expand Up @@ -241,6 +242,12 @@ def __init__(
self.to_visit_list = extract_urls_from_sitemap(_ensure_valid_url(base_url))

elif web_connector_type == WEB_CONNECTOR_VALID_SETTINGS.UPLOAD:
# Explicitly check if running in multi-tenant mode to prevent potential security risks
if MULTI_TENANT:
raise ValueError(
"Upload input for web connector is not supported in cloud environments"
)

logger.warning(
"This is not a UI supported Web Connector flow, "
"are you sure you want to do this?"
Expand Down
Loading